starocean999 commented on code in PR #48652: URL: https://github.com/apache/doris/pull/48652#discussion_r1984389287
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowLoadWarningsCommand.java: ########## @@ -0,0 +1,352 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.commands; + +import org.apache.doris.catalog.Column; +import org.apache.doris.catalog.Database; +import org.apache.doris.catalog.Env; +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.cloud.load.CloudLoadManager; +import org.apache.doris.common.Config; +import org.apache.doris.common.DdlException; +import org.apache.doris.common.ErrorCode; +import org.apache.doris.common.ErrorReport; +import org.apache.doris.common.FeConstants; +import org.apache.doris.common.util.NetUtils; +import org.apache.doris.datasource.InternalCatalog; +import org.apache.doris.load.Load; +import org.apache.doris.load.LoadJob; +import org.apache.doris.load.loadv2.LoadManager; +import org.apache.doris.mysql.privilege.PrivPredicate; +import org.apache.doris.nereids.analyzer.UnboundSlot; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.exceptions.ParseException; +import org.apache.doris.nereids.trees.expressions.CompoundPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.Or; +import org.apache.doris.nereids.trees.expressions.literal.IntegerLikeLiteral; +import org.apache.doris.nereids.trees.expressions.literal.VarcharLiteral; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.qe.ConnectContext; +import org.apache.doris.qe.ShowResultSet; +import org.apache.doris.qe.ShowResultSetMetaData; +import org.apache.doris.qe.StmtExecutor; +import org.apache.doris.system.Backend; +import org.apache.doris.system.SystemInfoService; + +import com.google.common.collect.Lists; +import org.apache.commons.collections.CollectionUtils; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.BufferedReader; +import java.io.InputStream; +import java.io.InputStreamReader; +import java.net.MalformedURLException; +import java.net.URL; +import java.net.URLConnection; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Show load warnings command. + */ +public class ShowLoadWarningsCommand extends ShowCommand { + private static final Logger LOG = LogManager.getLogger(ShowLoadWarningsCommand.class); + + private static final ShowResultSetMetaData META_DATA = ShowResultSetMetaData.builder() + .addColumn(new Column("JobId", ScalarType.createVarchar(15))) + .addColumn(new Column("Label", ScalarType.createVarchar(15))) + .addColumn(new Column("ErrorMsgDetail", ScalarType.createVarchar(100))) + .build(); + + private String dbName; + private Expression wildWhere; + private Long limit; + private String originUrl; + + public ShowLoadWarningsCommand(String dbName, Expression wildWhere, Long limit, String originUrl) { + super(PlanType.SHOW_LOAD_WARNINGS_COMMAND); + this.dbName = dbName; + this.wildWhere = wildWhere; + this.limit = limit; + this.originUrl = originUrl; + } + + private boolean isFindByLabel() { + return wildWhere != null && wildWhere instanceof EqualTo && ((EqualTo) wildWhere).left() instanceof UnboundSlot + && ((UnboundSlot) ((EqualTo) wildWhere).left()).getName().equalsIgnoreCase("label"); + } + + private boolean isFindByJobId() { + return wildWhere != null && wildWhere instanceof EqualTo && ((EqualTo) wildWhere).left() instanceof UnboundSlot + && ((UnboundSlot) ((EqualTo) wildWhere).left()).getName().equalsIgnoreCase("load_job_id"); + } + + @Override + public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { + return visitor.visitShowLoadWarningsCommand(this, context); + } + + private List<List<String>> showLoadWarningsFromUrl(URL url) throws Exception { + List<List<String>> rows = Lists.newArrayList(); + + URLConnection urlConnection = url.openConnection(); + InputStream inputStream = urlConnection.getInputStream(); + try (BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream))) { + while (reader.ready() && limit > 0) { + String line = reader.readLine(); + rows.add(Lists.newArrayList("-1", FeConstants.null_string, line)); + limit--; + } + } + return rows; + } + + private String getLabet(Expression right) { + return ((VarcharLiteral) right).getValue(); + } + + private long getJobId(Expression right) { + return ((IntegerLikeLiteral) right).getNumber().longValue(); + } + + private void checkAuth(Database db, String label) throws Exception { + Load load = Env.getCurrentEnv().getLoadInstance(); + long jobId = 0; + jobId = load.getLatestJobIdByLabel(db.getId(), label); + LoadJob job = load.getLoadJob(jobId); + if (job != null) { + Set<String> tableNames = job.getTableNames(); + if (tableNames.isEmpty()) { + // forward compatibility + if (!Env.getCurrentEnv().getAccessManager() + .checkDbPriv(ConnectContext.get(), InternalCatalog.INTERNAL_CATALOG_NAME, db.getFullName(), + PrivPredicate.SHOW)) { + ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR, + ConnectContext.get().getQualifiedUser(), db.getFullName()); + } + } else { + for (String tblName : tableNames) { + if (!Env.getCurrentEnv().getAccessManager() + .checkTblPriv(ConnectContext.get(), InternalCatalog.INTERNAL_CATALOG_NAME, db.getFullName(), + tblName, PrivPredicate.SHOW)) { + ErrorReport.reportAnalysisException(ErrorCode.ERR_TABLEACCESS_DENIED_ERROR, + "SHOW LOAD WARNINGS", + ConnectContext.get().getQualifiedUser(), ConnectContext.get().getRemoteIP(), + db.getFullName() + ": " + tblName); + } + } + } + } + } + + private List<List<String>> showLoadWarningsFromLabel(Database db, Expression right) throws Exception { + String label = getLabet(right); + + //from mysql load manager + String urlString = Env.getCurrentEnv().getLoadManager().getMysqlLoadManager().getErrorUrlByLoadId(label); + if (urlString != null && !urlString.isEmpty()) { + URL url; + try { + url = new URL(urlString); + } catch (MalformedURLException e) { + throw new AnalysisException("Invalid url: " + e.getMessage()); + } + return showLoadWarningsFromUrl(url); + } + + //from load manager + LoadManager loadManager = Env.getCurrentEnv().getLoadManager(); + List<List<Comparable>> loadJobInfosByDb; + if (!Config.isCloudMode()) { + loadJobInfosByDb = loadManager.getLoadJobInfosByDb(db.getId(), + label, + true, null); + } else { + loadJobInfosByDb = ((CloudLoadManager) loadManager) + .getLoadJobInfosByDb(db.getId(), + label, + true, null, null, null, false, null, false, null, false); + } + if (CollectionUtils.isEmpty(loadJobInfosByDb)) { + throw new AnalysisException("job is not exist."); + } + List<List<String>> infoList = Lists.newArrayListWithCapacity(loadJobInfosByDb.size()); + for (List<Comparable> comparables : loadJobInfosByDb) { + List<String> singleInfo = comparables.stream().map(Object::toString).collect(Collectors.toList()); + infoList.add(singleInfo); + } + + checkAuth(db, label); Review Comment: ```suggestion ``` from old code, when getting the result, the method return immediately: ``` ShowResultSet showResultSet = handleShowLoadWarningV2(showWarningsStmt, db); if (showResultSet != null) { resultSet = showResultSet; return; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
