yiguolei commented on code in PR #10631:
URL: https://github.com/apache/doris/pull/10631#discussion_r914459164
##########
be/src/olap/comparison_predicate.h:
##########
@@ -262,7 +263,71 @@ class ComparisonPredicateBase : public ColumnPredicate {
->get_data()
.data();
- _base_loop_vec<false>(size, flags, nullptr, data_array,
_value_real);
+ _base_loop_vec<false, false>(size, flags, nullptr, data_array,
_value_real);
+ }
+ }
+
+ if (_opposite) {
+ for (uint16_t i = 0; i < size; i++) {
+ flags[i] = !flags[i];
+ }
+ }
+ }
+
+ void evaluate_and_vec(const vectorized::IColumn& column, uint16_t size,
Review Comment:
这个代码的逻辑大部分跟 evaluate_vec 一样，是不是直接搞一个通用的函数，然后evalue_and 和 evaluate_and_vec
掉一把就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
