Lchangliang commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r914359505


##########
be/src/olap/convert_rowset.cpp:
##########
@@ -48,8 +48,9 @@ Status ConvertRowset::do_convert() {
 
         std::unique_ptr<RowsetWriter> output_rs_writer;
         RETURN_NOT_OK(_tablet->create_rowset_writer(output_version, VISIBLE, 
NONOVERLAPPING,
-                                                    &output_rs_writer));
-        res = Merger::merge_rowsets(_tablet, 
ReaderType::READER_BASE_COMPACTION, {input_rs_reader},
+                                                    &_tablet->tablet_schema(), 
&output_rs_writer));

Review Comment:
   But it need to be compile. Maybe someone is responsible for deleting related 
files together.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to