carlvinhust2012 commented on code in PR #10614:
URL: https://github.com/apache/doris/pull/10614#discussion_r913492986
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -1023,6 +1024,9 @@ Status HashJoinNode::_hash_table_build(RuntimeState*
state) {
int64_t last_mem_used = 0;
bool eos = false;
+ // make one block for each 4 gigabytes
+ constexpr static auto BUILD_BLOCK_MAX_SIZE = 4 * 1024UL * 1024UL * 1024UL;
Review Comment:
why not define this constexpr in 'class HashJoinNode'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
