koarz commented on code in PR #47319: URL: https://github.com/apache/doris/pull/47319#discussion_r1979678414
########## fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java: ########## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.analysis; + +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.Type; +import org.apache.doris.common.FormatOptions; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.thrift.TExprNode; +import org.apache.doris.thrift.TExprNodeType; +import org.apache.doris.thrift.TTimeV2Literal; + +public class TimeV2Literal extends LiteralExpr { + + public static final TimeV2Literal MIN_TIME = new TimeV2Literal(-838, 0, 0, 0, 0); + public static final TimeV2Literal MAX_TIME = new TimeV2Literal(838, 59, 59, 999999, 6); + + protected int hour; + protected int minute; + protected int second; + protected int microsecond; + protected boolean negative; + + /** + * C'tor forcing type, e.g., due to implicit cast + */ + // for restore + private TimeV2Literal() { + this.type = Type.TIMEV2; + this.hour = 0; + this.minute = 0; + this.second = 0; + this.microsecond = 0; + this.negative = false; + } + + public TimeV2Literal(double value) throws AnalysisException { + super(); + if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { + throw new AnalysisException("The value is out of range"); + } + this.type = ScalarType.createTimeV2Type(6); + this.negative = 1.0 / value < 0; + long v = (long) Math.abs(value); + this.microsecond = (int) (v % 1000000); + v /= 1000000; + this.second = (int) (v % 60); + v /= 60; + this.minute = (int) (v % 60); + v /= 60; + this.hour = (int) v; + analysisDone(); + } + + public TimeV2Literal(int hour, int minute, int second) throws AnalysisException { + super(); + this.type = Type.TIMEV2; + this.hour = Math.abs(hour); + this.minute = minute; + this.second = second; + this.microsecond = 0; + this.negative = hour < 0; + if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { + throw new AnalysisException("time literal is out of range"); + } + analysisDone(); + } + + public TimeV2Literal(int hour, int minute, int second, int microsecond, int scale) throws AnalysisException { + super(); + this.type = ScalarType.createTimeV2Type(scale); + this.hour = Math.abs(hour); + this.minute = minute; + this.second = second; + this.microsecond = microsecond; + while (microsecond != 0 && this.microsecond < 100000) { + this.microsecond *= 10; + } + this.negative = hour < 0; + if (checkRange(this.hour, this.minute, this.second, this.microsecond)) { + throw new AnalysisException("time literal is out of range"); + } + analysisDone(); + } + + public TimeV2Literal(String s) { + super(); + init(s); + analysisDone(); + } + + protected TimeV2Literal(TimeV2Literal other) { + super(other); + this.type = ScalarType.createTimeV2Type(((ScalarType) other.type).getScalarScale()); + this.hour = other.getHour(); + this.minute = other.getMinute(); + this.second = other.getSecond(); + this.microsecond = other.getMicroSecond(); + } + + @Override + public Expr clone() { + return new TimeV2Literal(this); + } + + protected String normalize(String s) { + // remove suffix/prefix ' ' + s = s.trim(); + if (s.charAt(0) == '-') { + s = s.substring(1); + negative = true; + } + if (!s.contains(":")) { + String tail = ""; + if (s.contains(".")) { + tail = s.substring(s.indexOf(".")); + s = s.substring(0, s.indexOf(".")); + } + int len = s.length(); + if (len == 1) { + s = "00:00:0" + s; + } else if (len == 2) { + s = "00:00:" + s; + } else if (len == 3) { + s = "00:0" + s.charAt(0) + ":" + s.substring(1); + } else if (len == 4) { + s = "00:" + s.substring(0, 2) + ":" + s.substring(2); + } else { + s = s.substring(0, len - 4) + ":" + s.substring(len - 4, len - 2) + ":" + s.substring(len - 2); + } + return s + tail; + } + // s maybe just contail 1 ":" like "12:00" so append a ":00" to the end + if (s.indexOf(':') == s.lastIndexOf(':')) { + s = s + ":00"; + } + return s; + } + + // should like be/src/vec/runtime/time_value.h timev2_to_double_from_str + protected void init(String s) throws AnalysisException { + s = normalize(s); + // start parse string + String[] parts = s.split(":"); + if (parts.length != 3) { + throw new AnalysisException("Invalid format, must have 3 parts separated by ':'"); + } + try { + hour = Integer.parseInt(parts[0]); + } catch (NumberFormatException e) { + throw new AnalysisException("Invalid hour format", e); + } + + try { + minute = Integer.parseInt(parts[1]); + } catch (NumberFormatException e) { + throw new AnalysisException("Invalid minute format", e); + } + + String[] secondParts = parts[2].split("\\."); + if (secondParts.length > 2) { + throw new AnalysisException("Invalid second format"); + } + + try { + second = Integer.parseInt(secondParts[0]); + } catch (NumberFormatException e) { + throw new AnalysisException("Invalid second format", e); + } + + if (((ScalarType) type).getScalarScale() != 0 && secondParts.length == 2) { + String microStr = secondParts[1]; + int len = microStr.length(); + + if (len > 6) { + microStr = microStr.substring(0, 6); + } + + StringBuilder sb = new StringBuilder(microStr); + while (sb.length() < 6) { + sb.append('0'); + } + + this.type = ScalarType.createTimeV2Type(len); + try { + microsecond = Integer.parseInt(sb.toString()); + } catch (NumberFormatException e) { + throw new AnalysisException("Invalid microsecond format", e); + } + } else { + microsecond = 0; + this.type = ScalarType.createTimeV2Type(0); + } + + if (checkRange(hour, minute, second, microsecond)) { + throw new AnalysisException("time literal [" + s + "] is out of range"); + } + } + + @Override + protected String toSqlImpl() { + return "\"" + getStringValue() + "\""; + } + + @Override + protected void toThrift(TExprNode msg) { + msg.node_type = TExprNodeType.TIMEV2_LITERAL; + msg.timev2_literal = new TTimeV2Literal(getValue()); + } + + @Override + public boolean isMinValue() { + // MAX_TIME and MIN_TIME just store every part min max value, so real time min is -MAX_TIME.getValue() + return getValue() == -MAX_TIME.getValue(); + } + + @Override + public int compareLiteral(LiteralExpr expr) { + return 0; + } + + @Override + public String getStringValue() { + StringBuilder sb = new StringBuilder(); + if (negative) { + sb.append("-"); + } + if (hour > 99) { + sb.append(String.format("%03d:%02d:%02d", hour, minute, second)); + } else { + sb.append(String.format("%02d:%02d:%02d", hour, minute, second)); + } + if (((ScalarType) type).getScalarScale() > 0) { + sb.append(String.format(".%0" + ((ScalarType) type).getScalarScale() + "d", microsecond)); + } + return sb.toString(); + } + + @Override + public String getStringValueForArray(FormatOptions options) { + return options.getNestedStringWrapper() + getStringValue() + options.getNestedStringWrapper(); + } + + protected static boolean checkRange(double hour, long minute, long second, long microsecond) { + return hour > 838 || minute > 59 || second > 59 || hour < 0 || minute < 0 || second < 0 Review Comment: but, if caller input negative as argument'TimeLiteral(-1,-1,-1,-1,-1)', the checkRange will not work corrently, because if we call getValue() it return false. minute > MAXTIME.minute(59) || minute < MINTIME.minute(59) always return true(except 59) , perhaps the variable name should be changed to make it more consistent with usage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
