csun5285 commented on code in PR #48625:
URL: https://github.com/apache/doris/pull/48625#discussion_r1979010223


##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -674,6 +677,11 @@ Status 
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap(
                             "Not support string len over than "
                             "`string_type_length_soft_limit_bytes` in vec 
engine.");
                 }
+                // Make sure that the json binary data written in is the 
correct jsonb value.
+                if (_is_jsonb && 
!doris::JsonbDocument::createDocument(slice->data, slice->size)) {

Review Comment:
   `_typed_column.type->get_type_id() == TypeIndex::JSONB`



##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -695,6 +703,11 @@ Status 
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap(
                         "Not support string len over than 
`string_type_length_soft_limit_bytes`"
                         " in vec engine.");
             }
+            // Make sure that the json binary data written in is the correct 
jsonb value.
+            if (_is_jsonb && 
!doris::JsonbDocument::createDocument(slice->data, slice->size)) {

Review Comment:
   _typed_column.type->get_type_id() == TypeIndex::JSONB



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to