englefly commented on code in PR #10552:
URL: https://github.com/apache/doris/pull/10552#discussion_r912311600
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -117,12 +117,17 @@ Status VOlapTableSink::send(RuntimeState* state,
vectorized::Block* input_block)
_partition_to_tablet_map.clear();
}
- //if pending bytes is more than 500M, wait
+ //if pending bytes is more than 500M, wait at most 1 min
constexpr size_t MAX_PENDING_BYTES = 500 * 1024 * 1024;
- if ( get_pending_bytes() > MAX_PENDING_BYTES){
- while(get_pending_bytes() < MAX_PENDING_BYTES){
- std::this_thread::sleep_for(std::chrono::microseconds(500));
- }
+ constexpr int max_retry = 120;
+ int retry = 0;
+ while (get_pending_bytes() > MAX_PENDING_BYTES && retry++ < max_retry) {
+ std::this_thread::sleep_for(std::chrono::microseconds(500));
+ }
+ if (get_pending_bytes() > MAX_PENDING_BYTES){
+ std::stringstream str;
+ str << "Load task " << _load_id << ": Memory exceed limit. ";
Review Comment:
more specific error message added
```
str << "Load task " << _load_id
<< ": pending bytes exceed limit
(config::table_sink_pending_bytes_limitation):"
<< MAX_PENDING_BYTES;
```
the limitation is not hard coded, it is a config now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
