924060929 commented on code in PR #48103:
URL: https://github.com/apache/doris/pull/48103#discussion_r1968812850
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/UuidNumeric.java:
##########
@@ -64,4 +81,28 @@ public List<FunctionSignature> getSignatures() {
public boolean isDeterministic() {
return false;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ UuidNumeric other = (UuidNumeric) o;
+ return exprId.equals(other.exprId);
+ }
+
+ // The contains method needs to use hashCode, so similar to equals, it
only compares exprId
+ @Override
+ public int computeHashCode() {
+ // direct return exprId to speed up
+ return exprId.asInt();
+ }
+
+ @Override
+ public int fastChildrenHashCode() {
+ return exprId.asInt();
Review Comment:
these functions should not override `fastChildrenHashCode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
