This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 6c70e034eac [fix](load) fix metrics memtable_flush_duration_us
(#47607) (#48211)
6c70e034eac is described below
commit 6c70e034eac4acf48f9e8acc1f781eb4ac517b09
Author: Kaijie Chen <[email protected]>
AuthorDate: Mon Feb 24 19:26:05 2025 +0800
[fix](load) fix metrics memtable_flush_duration_us (#47607) (#48211)
backport #47607
---
be/src/olap/memtable_flush_executor.cpp | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/be/src/olap/memtable_flush_executor.cpp
b/be/src/olap/memtable_flush_executor.cpp
index 3ea1dcae9f9..d2148396de1 100644
--- a/be/src/olap/memtable_flush_executor.cpp
+++ b/be/src/olap/memtable_flush_executor.cpp
@@ -133,18 +133,16 @@ Status FlushToken::_do_flush_memtable(MemTable* memtable,
int32_t segment_id, in
<< ", memsize: " << memtable->memory_usage()
<< ", rows: " << memtable->stat().raw_rows;
memtable->update_mem_type(MemType::FLUSH);
- int64_t duration_ns;
- SCOPED_RAW_TIMER(&duration_ns);
- SCOPED_ATTACH_TASK(memtable->query_thread_context());
- signal::set_signal_task_id(_rowset_writer->load_id());
- signal::tablet_id = memtable->tablet_id();
+ int64_t duration_ns = 0;
{
+ SCOPED_RAW_TIMER(&duration_ns);
+ SCOPED_ATTACH_TASK(memtable->query_thread_context());
SCOPED_CONSUME_MEM_TRACKER(memtable->mem_tracker());
std::unique_ptr<vectorized::Block> block;
RETURN_IF_ERROR(memtable->to_block(&block));
RETURN_IF_ERROR(_rowset_writer->flush_memtable(block.get(),
segment_id, flush_size));
+ memtable->set_flush_success();
}
- memtable->set_flush_success();
_memtable_stat += memtable->stat();
DorisMetrics::instance()->memtable_flush_total->increment(1);
DorisMetrics::instance()->memtable_flush_duration_us->increment(duration_ns /
1000);
@@ -155,6 +153,8 @@ Status FlushToken::_do_flush_memtable(MemTable* memtable,
int32_t segment_id, in
void FlushToken::_flush_memtable(std::shared_ptr<MemTable> memtable_ptr,
int32_t segment_id,
int64_t submit_task_time) {
+ signal::set_signal_task_id(_rowset_writer->load_id());
+ signal::tablet_id = memtable_ptr->tablet_id();
Defer defer {[&]() {
std::lock_guard<std::mutex> lock(_mutex);
_stats.flush_running_count--;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
