amorynan commented on code in PR #47889:
URL: https://github.com/apache/doris/pull/47889#discussion_r1959789793


##########
be/src/vec/data_types/serde/data_type_date64_serde.cpp:
##########
@@ -235,6 +242,23 @@ void DataTypeDate64SerDe::read_column_from_arrow(IColumn& 
column, const arrow::A
             v.cast_to_date();
             col_data.emplace_back(binary_cast<VecDateTimeValue, Int64>(v));
         }
+    } else if (arrow_array->type()->id() == arrow::Type::STRING) {
+        // to be compatible with old version, we use string type for date.
+        auto concrete_array = dynamic_cast<const 
arrow::StringArray*>(arrow_array);

Review Comment:
   this is just fix for write_to_arrow which will make beut core



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to