amorynan commented on code in PR #47965:
URL: https://github.com/apache/doris/pull/47965#discussion_r1959520806
##########
regression-test/suites/query_p0/aggregate/array_agg.groovy:
##########
@@ -276,6 +276,13 @@ suite("array_agg") {
order_qt_sql_array_agg_array """ SELECT id, array_agg(kastr) FROM
test_array_agg_complex GROUP BY id ORDER BY id """
order_qt_sql_array_agg_map """ SELECT id, array_agg(km) FROM
test_array_agg_complex GROUP BY id ORDER BY id """
order_qt_sql_array_agg_struct """ SELECT id, array_agg(ks) FROM
test_array_agg_complex GROUP BY id ORDER BY id """
+ order_qt_sql_collect_list_array """ SELECT id, collect_list(kastr) FROM
test_array_agg_complex GROUP BY id ORDER BY id """
Review Comment:
done!
##########
be/src/vec/aggregate_functions/aggregate_function_collect.cpp:
##########
@@ -49,6 +49,10 @@ AggregateFunctionPtr do_create_agg_function_collect(bool
distinct, const DataTyp
AggregateFunctionCollectListData<T, HasLimit>, HasLimit,
std::false_type>>(
argument_types, result_is_nullable);
}
+ } else if (!distinct) {
+ return creator_without_type::create<AggregateFunctionCollect<
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
