[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value

[GitBox]

BiteTheDDDDt commented on code in PR #10447:
URL: https://github.com/apache/doris/pull/10447#discussion_r907014191


##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -262,58 +266,31 @@ struct LeadAndLagData {
                 col.insert_default();

Review Comment:
   Maybe we can sympfy this function to two case `is_null` or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org