adonis0147 commented on PR #10236: URL: https://github.com/apache/doris/pull/10236#issuecomment-1166314957
I have some opinions about this pr: 1. It is better to add some documents to official website to guide users to use this Python API to do some jobs like stream load rather than add the source code to the repository. If someone else in community modifies the code, he (or she) may not notice to contribute the code to the upstream [DorisClient](https://github.com/TurboWay/DorisClient). It is hard to maintain duplicate code. You (@TurboWay ) can left the information in documents to guide users to give feedback to [DorisClient](https://github.com/TurboWay/DorisClient). 2. About performance, using [mysqlclient](https://pypi.org/project/mysqlclient/) instead of [PyMySQL](https://pypi.org/project/PyMySQL/) may speed the code up due to the C extension implementation. This pr inspires me that we can implement a python interactive tool to manage our cluster or do some jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
