morrySnow commented on code in PR #47363: URL: https://github.com/apache/doris/pull/47363#discussion_r1955666447
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalProject.java: ########## @@ -277,9 +277,13 @@ public void computeEqualSet(DataTrait.Builder builder) { public void computeFd(DataTrait.Builder builder) { builder.addFuncDepsDG(child().getLogicalProperties().getTrait()); for (NamedExpression expr : getProjects()) { - if (!expr.isSlot()) { - builder.addDeps(expr.getInputSlots(), ImmutableSet.of(expr.toSlot())); + if (!(expr instanceof Alias)) { Review Comment: why change `isSlot` to `instanceof Alias` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org