xzj7019 commented on code in PR #47864:
URL: https://github.com/apache/doris/pull/47864#discussion_r1955648562
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/Plan.java:
##########
@@ -250,7 +250,7 @@ default DataTrait computeDataTrait() {
for (Slot slot : getOutput()) {
Set<Slot> o = ImmutableSet.of(slot);
// all slots dependent unique slot
- for (Set<Slot> uniqueSlot : fdBuilder.getAllUniqueAndNotNull()) {
+ for (Set<Slot> uniqueSlot : fdBuilder.getAllUnique()) {
Review Comment:
not suggest to do this change currently since the uk constraints behavior is
not standard for different database impl and if the bc happens, it is easy to
ignore this place's dependence and introduce the risk, and another
consideration is the change is not CIR depended and testing cost is high if
this happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
