liaoxin01 commented on code in PR #47507:
URL: https://github.com/apache/doris/pull/47507#discussion_r1952596838
##########
cloud/src/meta-service/txn_kv_error.h:
##########
@@ -52,7 +52,7 @@ inline const char* format_as(TxnErrorCode code) {
case TxnErrorCode::TXN_INVALID_ARGUMENT: return "InvalidArgument";
case TxnErrorCode::TXN_KEY_TOO_LARGE: return "Key length exceeds limit";
case TxnErrorCode::TXN_VALUE_TOO_LARGE: return "Value length exceeds
limit";
- case TxnErrorCode::TXN_BYTES_TOO_LARGE: return "Transaction exceeds byte
limit";
+ case TxnErrorCode::TXN_BYTES_TOO_LARGE: return "Too many partitions to
load. Please reduce the number of partitions involved in the load.";
Review Comment:
The TXN_BYTES_TOO_LARGE error message is a low-level error that may be
utilized across multiple components. It would be more appropriate to append
detailed error context when this error code is caught at higher abstraction
layers. For instance, when encountering TXN_BYTES_TOO_LARGE during transaction
commit, we could include suggestions about partition reduction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
