BiteTheDDDDt commented on code in PR #47319:
URL: https://github.com/apache/doris/pull/47319#discussion_r1952150760


##########
be/src/vec/runtime/time_value.h:
##########
@@ -81,6 +81,67 @@ class TimeValue {
     static TimeType from_second(int64_t sec) {
         return static_cast<TimeType>(sec * ONE_SECOND_MICROSECONDS);
     }
+
+    static bool timev2_to_double_from_str(const char* str, double& v, int 
scale = 6) {
+        // like 
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java and
+        // 
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java
+        // init function to parse str
+        std::string s(str);
+        bool neg;

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to