adonis0147 commented on code in PR #10394: URL: https://github.com/apache/doris/pull/10394#discussion_r905763752
########## README.md: ########## @@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/ ## Compile and install -See [Compilation](https://doris.apache.org/install/source-install/compilation-with-ldb-toolchain.html) +See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html) Review Comment: Hi @Hisoka-X , I think it is better to recommend novices compile the codebase by [ldb toolchain](https://github.com/amosbird/ldb_toolchain_gen) for the following reasons: 1. It is difficult for users without root privilege to deploy `docker` on server. 2. It is easy to install [ldb toolchain](https://github.com/amosbird/ldb_toolchain_gen) and it is validated even on Centos 6. 3. [Dockerfile](https://github.com/apache/doris/blob/master/docker/Dockerfile) provided by Doris also uses [ldb toolchain](https://github.com/apache/doris/blob/9036f93df4a54e218c0ccb3ff2496bce39f5099d/docker/Dockerfile#L45) to build the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
