Gabriel39 commented on code in PR #9916:
URL: https://github.com/apache/doris/pull/9916#discussion_r905698872


##########
be/src/exec/olap_scan_node.cpp:
##########
@@ -1000,7 +1001,8 @@ std::pair<bool, void*> 
OlapScanNode::should_push_down_eq_predicate(doris::SlotDe
 
 template <typename T, typename ChangeFixedValueRangeFunc>
 Status OlapScanNode::change_fixed_value_range(ColumnValueRange<T>& temp_range, 
PrimitiveType type,
-                                              void* value, const 
ChangeFixedValueRangeFunc& func) {
+                                              void* value, const 
ChangeFixedValueRangeFunc& func,
+                                              PrimitiveType to_type) {

Review Comment:
   This argument is added in order to meet patterns like `cast(datev2 as 
datetimev2)`. Since datetimev2 has not been  supported, this argument is indeed 
not used now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to