This is an automated email from the ASF dual-hosted git repository.

hellostephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 7c70506725b [fix](docker)  Starting thirdpaty script with only the 
reserve-ports parameter does not work (#47578)
7c70506725b is described below

commit 7c70506725b685c0ecab0f85386daf11d282e016
Author: zgxme <[email protected]>
AuthorDate: Fri Feb 7 15:41:38 2025 +0800

    [fix](docker)  Starting thirdpaty script with only the reserve-ports 
parameter does not work (#47578)
    
    ### What problem does this PR solve?
    
    Related PR: https://github.com/apache/doris/pull/47262
    
    Problem Summary:
    Starting thirdpaty script with only the reserve-ports parameter does not
    work
    ```bash
    ./run-thirdparties-docker.sh --reserve-ports
    ```
---
 docker/thirdparties/run-thirdparties-docker.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/docker/thirdparties/run-thirdparties-docker.sh 
b/docker/thirdparties/run-thirdparties-docker.sh
index 9cb3dae2c45..aa3dbee26e1 100755
--- a/docker/thirdparties/run-thirdparties-docker.sh
+++ b/docker/thirdparties/run-thirdparties-docker.sh
@@ -42,6 +42,8 @@ Usage: $0 <options>
   "
     exit 1
 }
+DEFAULT_COMPONENTS="mysql,es,hive2,hive3,pg,oracle,sqlserver,clickhouse,mariadb,iceberg,db2,oceanbase,kerberos,minio"
+ALL_COMPONENTS="${DEFAULT_COMPONENTS},hudi,trino,kafka,spark,lakesoul"
 COMPONENTS=$2
 HELP=0
 STOP=0
@@ -62,7 +64,7 @@ eval set -- "${OPTS}"
 
 if [[ "$#" == 1 ]]; then
     # default
-    
COMPONENTS="mysql,es,hive2,hive3,pg,oracle,sqlserver,clickhouse,mariadb,iceberg,db2,oceanbase,kerberos,minio"
+    COMPONENTS="${DEFAULT_COMPONENTS}"
 else
     while true; do
         case "$1" in
@@ -98,7 +100,10 @@ else
     done
     if [[ "${COMPONENTS}"x == ""x ]]; then
         if [[ "${STOP}" -eq 1 ]]; then
-            
COMPONENTS="mysql,es,pg,oracle,sqlserver,clickhouse,hive2,hive3,iceberg,hudi,trino,kafka,mariadb,db2,oceanbase,kerberos,lakesoul"
+            COMPONENTS="${ALL_COMPONENTS}"
+        fi
+        if [[ "${NEED_RESERVE_PORTS}" -eq 1 ]]; then
+            COMPONENTS="${DEFAULT_COMPONENTS}"
         fi
     fi
 fi


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to