[doris] branch master updated: [feature](nereids)temporary disable exploration jobs in cascades (#10290)

[lingmiao]

This is an automated email from the ASF dual-hosted git repository.

lingmiao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 8204b41d88 [feature](nereids)temporary disable exploration jobs in 
cascades (#10290)
8204b41d88 is described below

commit 8204b41d88db1f4906e082ccc60e560377ac53c9
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Wed Jun 22 20:05:01 2022 +0800

    [feature](nereids)temporary disable exploration jobs in cascades (#10290)
    
    Only do implementation in cascades.
    
    In order to achieve the ssb test, at this stage, temporarily comment out 
the explore rule process in cascades.
    It needs to be added in the future.
---
 .../doris/nereids/jobs/cascades/ExploreGroupExpressionJob.java     | 7 +++++--
 .../doris/nereids/jobs/cascades/OptimizeGroupExpressionJob.java    | 6 +++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ExploreGroupExpressionJob.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ExploreGroupExpressionJob.java
index 73dc398ff3..b2f1da9a8e 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ExploreGroupExpressionJob.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/ExploreGroupExpressionJob.java
@@ -26,6 +26,8 @@ import org.apache.doris.nereids.pattern.Pattern;
 import org.apache.doris.nereids.rules.Rule;
 import org.apache.doris.nereids.trees.plans.Plan;
 
+import com.google.common.collect.Lists;
+
 import java.util.Comparator;
 import java.util.List;
 
@@ -48,11 +50,12 @@ public class ExploreGroupExpressionJob extends Job<Plan> {
 
     @Override
     public void execute() {
-        List<Rule<Plan>> explorationRules = getRuleSet().getExplorationRules();
+        // TODO: enable exploration job after we test it
+        // List<Rule<Plan>> explorationRules = 
getRuleSet().getExplorationRules();
+        List<Rule<Plan>> explorationRules = Lists.newArrayList();
         List<Rule<Plan>> validRules = getValidRules(groupExpression, 
explorationRules);
         validRules.sort(Comparator.comparingInt(o -> 
o.getRulePromise().promise()));
 
-        // TODO: adapt situation when pattern arity smaller than group 
expression arity
         for (Rule<Plan> rule : validRules) {
             pushTask(new ApplyRuleJob(groupExpression, rule, context));
             for (int i = 0; i < rule.getPattern().children().size(); ++i) {
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/OptimizeGroupExpressionJob.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/OptimizeGroupExpressionJob.java
index 48f7ca9c3f..83f699e640 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/OptimizeGroupExpressionJob.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/OptimizeGroupExpressionJob.java
@@ -44,9 +44,10 @@ public class OptimizeGroupExpressionJob extends Job<Plan> {
     @Override
     public void execute() {
         List<Rule<Plan>> validRules = new ArrayList<>();
-        List<Rule<Plan>> explorationRules = getRuleSet().getExplorationRules();
         List<Rule<Plan>> implementationRules = 
getRuleSet().getImplementationRules();
-        validRules.addAll(getValidRules(groupExpression, explorationRules));
+        // TODO: enable exploration job after we test it
+        // List<Rule<Plan>> explorationRules = 
getRuleSet().getExplorationRules();
+        // validRules.addAll(getValidRules(groupExpression, explorationRules));
         validRules.addAll(getValidRules(groupExpression, implementationRules));
         validRules.sort(Comparator.comparingInt(o -> 
o.getRulePromise().promise()));
 
@@ -55,7 +56,6 @@ public class OptimizeGroupExpressionJob extends Job<Plan> {
 
             // If child_pattern has any more children (i.e non-leaf), then we 
will explore the
             // child before applying the rule. (assumes task pool is 
effectively a stack)
-            // TODO: adapt situation when pattern arity smaller than group 
expression arity
             for (int i = 0; i < rule.getPattern().children().size(); ++i) {
                 Pattern childPattern = rule.getPattern().child(i);
                 if (childPattern.arity() > 0 && !childPattern.isGroup()) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org