zhannngchen commented on code in PR #47028:
URL: https://github.com/apache/doris/pull/47028#discussion_r1940388500


##########
be/src/cloud/cloud_tablet_mgr.h:
##########
@@ -82,6 +82,9 @@ class CloudTabletMgr {
 
     void get_tablet_info(int64_t num_tablets, std::vector<TabletInfo>* 
tablets_info);
 
+    void get_topn_tablet_delete_bitmap_score(uint64_t* max_delete_bitmap_score,

Review Comment:
   It's better to support a parameter `int n` if your method name contains 
`topn`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to