morrySnow commented on code in PR #1851:
URL: https://github.com/apache/doris-website/pull/1851#discussion_r1920082671
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/url-encode.md:
##########
@@ -4,3 +4,50 @@
"language": "zh-CN"
}
---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+
+## 描述
+
+使用 UTF-8 编码完成所提供文本的 URL 编码。通常用于对作为 URL 的一部分传递的参数信息进行编码
+
+## 语法
+
+```sql
+URL_ENCODE(' STRING ')
+```
+
+## 必选参数
Review Comment:
```suggestion
## 参数
```
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/trim.md:
##########
@@ -24,18 +24,23 @@ specific language governing permissions and limitations
under the License.
-->
-## trim
+
## 描述
-## 语法
-`VARCHAR trim(VARCHAR str[, VARCHAR rhs])`
+用于删除字符串两端的空格或指定字符
+## 语法
+```sql
+trim( str [, VARCHAR rhs])
+```
+
Review Comment:
缺少参数和返回值章节
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/url-decode.md:
##########
@@ -24,31 +24,31 @@ specific language governing permissions and limitations
under the License.
-->
-## url_decode
+
+
## 描述
将URL转换为解码字符串。
## 语法
```sql
-VARCHAR url_decode(VARCHAR url)
+URL_DECODE(' STRING ')
```
### Parameters
Review Comment:
中文文档的章节名需要用中文
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/ucase.md:
##########
@@ -24,14 +24,28 @@ specific language governing permissions and limitations
under the License.
-->
-## ucase
+
## 描述
-## 语法
-`VARCHAR ucase(VARCHAR str)`
+用于将字符串转换为大写字母
+
+## 别名
+
+- upper
+
+## 语法
+```sql
+ucase(string)
+```
-将参数中所有的字符串都转换成大写，此函数的另一个别名为[upper](./upper.md)。
+### 示例
-### keywords
- UCASE
+```sql
+mysql> SELECT ucase("aBc123");
Review Comment:
不用能 prompt
```suggestion
SELECT ucase("aBc123");
```
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/url-encode.md:
##########
@@ -4,3 +4,50 @@
"language": "zh-CN"
}
---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+
+## 描述
+
+使用 UTF-8 编码完成所提供文本的 URL 编码。通常用于对作为 URL 的一部分传递的参数信息进行编码
+
+## 语法
+
+```sql
+URL_ENCODE(' STRING ')
+```
+
+## 必选参数
+
+- STRING: 待编码的字符串。
+
+## 示例
+
+```sql
+mysql> select URL_ENCODE('Doris Q&A');
Review Comment:
结果和查询要分成两个code block
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/trim.md:
##########
@@ -24,18 +24,23 @@ specific language governing permissions and limitations
under the License.
-->
-## trim
+
## 描述
-## 语法
-`VARCHAR trim(VARCHAR str[, VARCHAR rhs])`
+用于删除字符串两端的空格或指定字符
+## 语法
+```sql
+trim( str [, VARCHAR rhs])
Review Comment:
1. 函数名大写
2. 不需要参数类型
3. 参数需要用尖括号包裹
```suggestion
TRIM( <str> [, <rhs> ])
```
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/scalar-functions/string-functions/url-encode.md:
##########
@@ -4,3 +4,50 @@
"language": "zh-CN"
}
---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+
+## 描述
+
+使用 UTF-8 编码完成所提供文本的 URL 编码。通常用于对作为 URL 的一部分传递的参数信息进行编码
+
+## 语法
+
+```sql
+URL_ENCODE(' STRING ')
+```
+
+## 必选参数
+
+- STRING: 待编码的字符串。
Review Comment:
参数需要时表格形式
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
