morrySnow commented on code in PR #1849:
URL: https://github.com/apache/doris-website/pull/1849#discussion_r1920072700


##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/append-trailing-char-if-absent.md:
##########
@@ -24,37 +24,37 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-## append_trailing_char_if_absent
+## Description
 
-### description
+Used to add a specific character (such as a space, a specific symbol, etc.) to 
the end of a string if the character does not exist at the end of the string. 
The function is to ensure that the string ends with a specific character.
 
-#### Syntax
+## Syntax
 
-`VARCHAR append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)`
+```sql
+append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)

Review Comment:
   1. 函数名大写
   2. 不需要参数类型
   3. 参数用尖括号包起来
   ```suggestion
   APPEND_TRAILING_CHAR_IF_ABSENT(<str>, <trailing_char>)
   ```



##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/append-trailing-char-if-absent.md:
##########
@@ -24,37 +24,37 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-## append_trailing_char_if_absent
+## Description
 
-### description
+Used to add a specific character (such as a space, a specific symbol, etc.) to 
the end of a string if the character does not exist at the end of the string. 
The function is to ensure that the string ends with a specific character.
 
-#### Syntax
+## Syntax
 
-`VARCHAR append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)`
+```sql
+append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)
+```
 
-If the @str string is non-empty and does not contain the @trailing_char 
character at the end, it appends the @trailing_char character to the end.
-@trailing_char contains only one character, and it will return NULL if 
contains more than one character
+## Parameters
 
-### example
+| Parameters | Description |
+| -- |-----------------------------|
+| `str` | Target string to be judged |
+| `trailing_char` | Character to be added to the end of the string (if the 
character does not exist) |

Review Comment:
   ```suggestion
   | `<trailing_char>` | Character to be added to the end of the string (if the 
character does not exist) |
   ```



##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/concat.md:
##########
@@ -24,38 +24,40 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-## concat
-### Description
-#### Syntax
+## Description
 
-`VARCHAR concat (VARCHAR,...)`
+Concatenate multiple strings. Special cases:
 
+- If any of the parameter values ​​is NULL, the result returned is NULL
 
-Connect multiple strings and return NULL if any of the parameters is NULL
-
-### example
+## Syntax
 
+```sql
+concat(STRING <expr1> [ ,STRING <expr2> ... ])
 ```
-mysql> select concat("a", "b");
-+------------------+
-| concat('a', 'b') |
-+------------------+
-| ab               |
-+------------------+
-
-mysql> select concat("a", "b", "c");
-+-----------------------+
-| concat('a', 'b', 'c') |
-+-----------------------+
-| abc                   |
-+-----------------------+
-
-mysql> select concat("a", null, "c");
-+------------------------+
-| concat('a', NULL, 'c') |
-+------------------------+
-| NULL                   |
-+------------------------+
+
+## Parameters
+
+| Parameter | Description |
+| -- |--------------|
+| `<expr1>` | The string to be concatenated |

Review Comment:
   ```suggestion
   | `<expr>` | The string to be concatenated |
   ```



##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/concat.md:
##########
@@ -24,38 +24,40 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-## concat
-### Description
-#### Syntax
+## Description
 
-`VARCHAR concat (VARCHAR,...)`
+Concatenate multiple strings. Special cases:
 
+- If any of the parameter values ​​is NULL, the result returned is NULL
 
-Connect multiple strings and return NULL if any of the parameters is NULL
-
-### example
+## Syntax
 
+```sql
+concat(STRING <expr1> [ ,STRING <expr2> ... ])

Review Comment:
   ```suggestion
   CONCAT(<expr> [ , <expr> ... ])
   ```



##########
docs/sql-manual/sql-functions/scalar-functions/string-functions/append-trailing-char-if-absent.md:
##########
@@ -24,37 +24,37 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-## append_trailing_char_if_absent
+## Description
 
-### description
+Used to add a specific character (such as a space, a specific symbol, etc.) to 
the end of a string if the character does not exist at the end of the string. 
The function is to ensure that the string ends with a specific character.
 
-#### Syntax
+## Syntax
 
-`VARCHAR append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)`
+```sql
+append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)
+```
 
-If the @str string is non-empty and does not contain the @trailing_char 
character at the end, it appends the @trailing_char character to the end.
-@trailing_char contains only one character, and it will return NULL if 
contains more than one character
+## Parameters
 
-### example
+| Parameters | Description |
+| -- |-----------------------------|
+| `str` | Target string to be judged |

Review Comment:
   ```suggestion
   | `<str>` | Target string to be judged |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to