HappenLee commented on code in PR #10103: URL: https://github.com/apache/doris/pull/10103#discussion_r899969452
########## be/src/vec/exprs/vbloom_predicate.h: ########## @@ -0,0 +1,48 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "exprs/bloomfilter_predicate.h" +#include "vec/exprs/vexpr.h" + +namespace doris::vectorized { +class VBloomPredicate final : public VExpr { +public: + VBloomPredicate(const TExprNode& node); + ~VBloomPredicate() = default; + virtual doris::Status execute(VExprContext* context, doris::vectorized::Block* block, + int* result_column_id) override; + virtual doris::Status prepare(doris::RuntimeState* state, const doris::RowDescriptor& desc, + VExprContext* context) override; + virtual doris::Status open(doris::RuntimeState* state, VExprContext* context, + FunctionContext::FunctionStateScope scope) override; + virtual void close(doris::RuntimeState* state, VExprContext* context, + FunctionContext::FunctionStateScope scope) override; + virtual VExpr* clone(doris::ObjectPool* pool) const override { + return pool->add(new VBloomPredicate(*this)); + } + virtual const std::string& expr_name() const override; + void set_filter(IBloomFilterFuncBase* filter); Review Comment: this interface is danger will cause double deleteļ¼ if no need delete the interface ########## be/src/vec/exprs/vbloom_predicate.h: ########## @@ -0,0 +1,48 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "exprs/bloomfilter_predicate.h" +#include "vec/exprs/vexpr.h" + +namespace doris::vectorized { +class VBloomPredicate final : public VExpr { +public: + VBloomPredicate(const TExprNode& node); + ~VBloomPredicate() = default; + virtual doris::Status execute(VExprContext* context, doris::vectorized::Block* block, Review Comment: `final` not need `virtual` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
