morrySnow commented on code in PR #10194: URL: https://github.com/apache/incubator-doris/pull/10194#discussion_r899721781
########## fe/fe-core/src/main/java/org/apache/doris/nereids/operators/plans/logical/LogicalScan.java: ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.operators.plans.logical; + +import org.apache.doris.nereids.operators.OperatorType; + +import java.util.List; +import java.util.Objects; + +/** + * Abstract class for logical scan plan operator. + */ +public abstract class LogicalScan extends LogicalLeafOperator { Review Comment: we already have LogicalRelation, it is the same thing with LogicalScan ########## fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java: ########## @@ -106,6 +115,15 @@ public void setStatDerived(boolean statDerived) { this.statDerived = statDerived; } + public Map<PhysicalProperties, Pair<Double, List<PhysicalProperties>>> getLowestCostTable() { Review Comment: it is not a good idea to add these things in this PR ########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java: ########## @@ -37,6 +37,11 @@ public enum RuleType { // implementation rules LOGICAL_JOIN_TO_HASH_JOIN_RULE(RuleTypeClass.IMPLEMENTATION), + Projection(RuleTypeClass.IMPLEMENTATION), + Filter(RuleTypeClass.IMPLEMENTATION), + Limit(RuleTypeClass.IMPLEMENTATION), + HashAgg(RuleTypeClass.IMPLEMENTATION), + OLAP_SCAN(RuleTypeClass.IMPLEMENTATION), Review Comment: ```suggestion LOGICAL_PROJECT_TO_PHYSICAL_PROJECT(RuleTypeClass.IMPLEMENTATION), LOGICAL_FILTER_TO_PHYSICAL_FILTER(RuleTypeClass.IMPLEMENTATION), LOGICAL_AGGREGATE_TO_PHYSICAL_HASH_AGGREGATE(RuleTypeClass.IMPLEMENTATION), LOGICAL_OLAP_SCAN_TO_PHYSICAL_OLAP_SCAN(RuleTypeClass.IMPLEMENTATION), ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
