Gabriel39 commented on code in PR #46789:
URL: https://github.com/apache/doris/pull/46789#discussion_r1915850701
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -244,6 +244,7 @@ class BloomFilterFuncBase : public RuntimeFilterFuncBase {
_bloom_filter = other_func->_bloom_filter;
_inited = other_func->_inited;
_enable_fixed_len_to_uint32_v2 |=
other_func->_enable_fixed_len_to_uint32_v2;
+ set_filter_id(bloomfilter_func->get_filter_id());
Review Comment:
Why reset filter id here? Should we set it during initialization?
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -503,15 +503,9 @@ class RuntimePredicateWrapper {
switch (_filter_type) {
case RuntimeFilterType::IN_FILTER: {
- if (!_context->hybrid_set) {
Review Comment:
DCHECK(_context->hybrid_set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
