eldenmoon commented on code in PR #46977:
URL: https://github.com/apache/doris/pull/46977#discussion_r1915163230
##########
be/src/util/jsonb_parser_simd.h:
##########
@@ -290,9 +290,21 @@ class JsonbParserTSIMD {
}
}
- void write_number(simdjson::ondemand::number num) {
+ void write_number(simdjson::ondemand::number num, std::string_view
raw_string) {
if (num.is_double()) {
- if (writer_.writeDouble(num.get_double()) == 0) {
+ double number = num.get_double();
+ // When a double exceeds the precision that can be represented by
a double type in simdjson, it gets converted to 0.
+ // The correct approach, should be to truncate the double value
instead.
+ if (number == 0) {
+ StringParser::ParseResult result;
+ number =
StringParser::string_to_float<double>(raw_string.data(), raw_string.size(),
+ &result);
+ if (result != StringParser::PARSE_SUCCESS) {
+ number = 0;
Review Comment:
maybe throw exception here, can't reach here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
