HappenLee commented on code in PR #46181:
URL: https://github.com/apache/doris/pull/46181#discussion_r1912700898
##########
be/src/pipeline/exec/analytic_sink_operator.h:
##########
@@ -37,34 +68,94 @@ class AnalyticSinkLocalState : public
PipelineXSinkLocalState<AnalyticSharedStat
Status init(RuntimeState* state, LocalSinkStateInfo& info) override;
Status open(RuntimeState* state) override;
+ Status close(RuntimeState* state, Status exec_status) override;
private:
friend class AnalyticSinkOperatorX;
+ Status _execute_impl();
+ bool _get_next_for_partition(int64_t batch_rows, int64_t
current_block_base_pos);
Review Comment:
add comment for all get_next function !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
