yiguolei commented on code in PR #46564:
URL: https://github.com/apache/doris/pull/46564#discussion_r1910241053
##########
fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java:
##########
@@ -75,18 +75,25 @@ private QeProcessorImpl() {
private Status processQueryProfile(TQueryProfile profile, TNetworkAddress
address, boolean isDone) {
ExecutionProfile executionProfile =
ProfileManager.getInstance().getExecutionProfile(profile.query_id);
if (executionProfile == null) {
- LOG.warn("Could not find execution profile with query id {}",
DebugUtil.printId(profile.query_id));
+ LOG.warn("Could not find execution profile, query {} be {}",
+ DebugUtil.printId(profile.query_id),
address.toString());
return new Status(TStatusCode.NOT_FOUND, "Could not find execution
profile with query id "
+ DebugUtil.printId(profile.query_id));
}
- // Update profile may cost a lot of time, use a seperate pool to deal
with it.
- writeProfileExecutor.submit(new Runnable() {
- @Override
- public void run() {
- executionProfile.updateProfile(profile, address, isDone);
- }
- });
+ // Update profile may cost a lot of time, use a separate pool to deal
with it.
+ try {
+ writeProfileExecutor.submit(new Runnable() {
+ @Override
+ public void run() {
+ executionProfile.updateProfile(profile, address, isDone);
+ }
+ });
+ } catch (Exception e) {
+ LOG.warn("Failed to submit profile write task, query {} be {}",
+ DebugUtil.printId(profile.query_id),
address.toString());
+ return new Status(TStatusCode.INTERNAL_ERROR, "Failed to submit
profile write task");
Review Comment:
如果这里返回失败，会不会BE 收到这个错误，导致查询失败？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
