amorynan commented on code in PR #46639:
URL: https://github.com/apache/doris/pull/46639#discussion_r1908101640
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -627,8 +627,9 @@ private boolean processModifyColumn(ModifyColumnClause
alterClause, OlapTable ol
if (!col.equals(modColumn)) {
typeChanged = true;
// TODO:the case where columnPos is not empty has not been
considered
- if (columnPos == null && col.getDataType() ==
PrimitiveType.VARCHAR
- && modColumn.getDataType() ==
PrimitiveType.VARCHAR) {
+ if (columnPos == null && ((col.getDataType() ==
PrimitiveType.VARCHAR
+ && modColumn.getDataType() ==
PrimitiveType.VARCHAR)
+ || col.getDataType().isComplexType())) {
Review Comment:
I write a isSupportSchemaChangeForCharType for this, here just a pass to
call checkSchemaChangeAllowed which can check is support or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
