eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903927097
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -905,17 +945,11 @@ void ColumnObject::try_insert(const Field& field) {
// Insert to an emtpy ColumnObject may result root null,
// so create a root column of Variant is expected.
if (root == nullptr) {
- bool succ = add_sub_column({}, num_rows);
- if (!succ) {
- throw doris::Exception(doris::ErrorCode::INVALID_ARGUMENT,
- "Failed to add root sub column {}");
- }
- root = get_subcolumn({});
+ CHECK(false);
Review Comment:
add CHECK(false) << "xxxx" , to decribe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
