This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git

commit 519082831984fbf6706146211f2d9c0ce8f2475c
Author: morningman <morning...@163.com>
AuthorDate: Fri Jun 10 23:48:07 2022 +0800

    [Bug] [Vectorized] code dump on aggregate node over union node (#10040)
    
    * miss check passthrough on vectorized
    
    * format and add test
    
    * update
---
 .../src/main/java/org/apache/doris/planner/SetOperationNode.java   | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java 
b/fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
index 93082e3e30..238f772726 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java
@@ -270,9 +270,16 @@ public abstract class SetOperationNode extends PlanNode {
                 return false;
             }
             if (VectorizedUtil.isVectorized()) {
+                // On vectorized engine, we have more chance to do passthrough.
                 if (childSlotRef.getDesc().getSlotOffset() != 
setOpSlotRef.getDesc().getSlotOffset()) {
                     return false;
                 }
+                if (childSlotRef.isNullable() != setOpSlotRef.isNullable()) {
+                    return false;
+                }
+                if (childSlotRef.getDesc().getType() != 
setOpSlotRef.getDesc().getType()) {
+                    return false;
+                }
             } else {
                 if 
(!childSlotRef.getDesc().LayoutEquals(setOpSlotRef.getDesc())) {
                     return false;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to