zhannngchen commented on code in PR #46347:
URL: https://github.com/apache/doris/pull/46347#discussion_r1901734456
##########
be/src/olap/partial_update_info.cpp:
##########
@@ -48,6 +50,21 @@ void PartialUpdateInfo::init(const TabletSchema&
tablet_schema,
missing_cids.clear();
update_cids.clear();
+ if (partial_update_mode == UniqueKeyUpdateModePB::UPDATE_FIXED_COLUMNS) {
+ // partial_update_cols should include all key columns
+ for (std::size_t i {0}; i < tablet_schema.num_key_columns(); i++) {
+ const auto key_col = tablet_schema.column(i);
+ if (!partial_update_cols.contains(key_col.name())) {
+ auto msg = fmt::format(
+ "Unable to do partial update on shadow index's tablet,
tablet_id={}, "
+ "txn_id={}. Missing key column {}.",
+ tablet_id, txn_id, key_col.name());
+ LOG_WARNING(msg);
+ return Status::Aborted<false>(msg);
Review Comment:
Is INVALID_SCHEMA error better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
