suxiaogang223 opened a new pull request, #46372:
URL: https://github.com/apache/doris/pull/46372
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #45740
Problem Summary:
This pull request includes several changes to the `ColumnChunkReader` class
and its methods in the file
`be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp`. The main
focus is on improving the handling of dictionary pages and simplifying the code.
Improvements to dictionary page handling:
*
[`ColumnChunkReader::init()`](diffhunk://#diff-97f77661f2bd0292ee695640daa792b52bd58f04a026929e2ee6a9ded0f53977L74-R75):
Re-enabled the dictionary page parsing by uncommenting the calls to
`_page_reader->next_page_header()` and `_decode_dict_page()`.
*
[`ColumnChunkReader::next_page()`](diffhunk://#diff-97f77661f2bd0292ee695640daa792b52bd58f04a026929e2ee6a9ded0f53977L96-L109):
Removed the logic for checking and decoding dictionary pages, as this is now
handled in the `init()` method.
Code simplification:
*
[`ColumnChunkReader::load_page_data()`](diffhunk://#diff-97f77661f2bd0292ee695640daa792b52bd58f04a026929e2ee6a9ded0f53977R120-R121):
Added a DCHECK to ensure that the page header is not a dictionary page.
* `ColumnChunkReader` class: Removed the `_dict_checked` member variable, as
it is no longer needed.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
