This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push: new f5ed36065b2 branch-3.0: [Bug](scan) do not release tablet_reader on NewOlapScanner::close #46296 (#46354) f5ed36065b2 is described below commit f5ed36065b24c123b05f01aef0f36b8476bfad96 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Fri Jan 3 16:31:41 2025 +0800 branch-3.0: [Bug](scan) do not release tablet_reader on NewOlapScanner::close #46296 (#46354) Cherry-picked from #46296 Co-authored-by: Pxl <x...@selectdb.com> --- be/src/vec/exec/scan/new_olap_scanner.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/be/src/vec/exec/scan/new_olap_scanner.cpp b/be/src/vec/exec/scan/new_olap_scanner.cpp index f40f30f5b16..f2ca2f0731b 100644 --- a/be/src/vec/exec/scan/new_olap_scanner.cpp +++ b/be/src/vec/exec/scan/new_olap_scanner.cpp @@ -524,14 +524,6 @@ Status NewOlapScanner::close(RuntimeState* state) { return Status::OK(); } - // olap scan node will call scanner.close() when finished - // will release resources here - // if not clear rowset readers in read_params here - // readers will be release when runtime state deconstructed but - // deconstructor in reader references runtime state - // so that it will core - _tablet_reader_params.rs_splits.clear(); - _tablet_reader.reset(); RETURN_IF_ERROR(VScanner::close(state)); return Status::OK(); } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org