HappenLee commented on code in PR #10003:
URL: https://github.com/apache/incubator-doris/pull/10003#discussion_r893341182
##########
be/src/vec/columns/column.h:
##########
@@ -199,14 +201,22 @@ class IColumn : public COW<IColumn> {
LOG(FATAL) << "Method insert_many_binary_data is not supported for "
<< get_name();
}
+ virtual void insert_many_data(const char* pos, size_t length, size_t
data_num) {
Review Comment:
the function seems not need be `virtual`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
