yiguolei commented on code in PR #10013: URL: https://github.com/apache/incubator-doris/pull/10013#discussion_r893218281
########## be/src/vec/sink/vresult_file_sink.h: ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "runtime/result_file_sink.h" +#include "vec/sink/vdata_stream_sender.h" + +namespace doris { +namespace vectorized { +class VResultWriter; + +class VResultFileSink : public VDataStreamSender { +public: + VResultFileSink(ObjectPool* pool, const RowDescriptor& row_desc, const TResultFileSink& sink, + int per_channel_buffer_size, bool send_query_statistics_with_every_batch, + const std::vector<TExpr>& t_output_expr); + VResultFileSink(ObjectPool* pool, int sender_id, const RowDescriptor& row_desc, + const TResultFileSink& sink, + const std::vector<TPlanFragmentDestination>& destinations, + int per_channel_buffer_size, bool send_query_statistics_with_every_batch, + const std::vector<TExpr>& t_output_expr, DescriptorTbl& descs); + virtual ~VResultFileSink(); + virtual Status init(const TDataSink& thrift_sink) override; + virtual Status prepare(RuntimeState* state) override; + virtual Status open(RuntimeState* state) override; + // send data in 'batch' to this backend stream mgr + // Blocks until all rows in batch are placed in the buffer + virtual Status send(RuntimeState* state, RowBatch* batch) override; + virtual Status send(RuntimeState* state, Block* block) override; + // Flush all buffered data and close all existing channels to destination + // hosts. Further send() calls are illegal after calling close(). + virtual Status close(RuntimeState* state, Status exec_status) override; + virtual RuntimeProfile* profile() override { return _profile; } + + void set_query_statistics(std::shared_ptr<QueryStatistics> statistics) override; + +private: + Status prepare_exprs(RuntimeState* state); + // set file options when sink type is FILE + std::unique_ptr<ResultFileOptions> _file_opts; + TStorageBackendType::type _storage_type; + + // Owned by the RuntimeState. + const std::vector<TExpr>& _t_output_expr; + std::vector<ExprContext*> _output_expr_ctxs; + RowDescriptor _output_row_descriptor; + + Block* _output_block = nullptr; Review Comment: use unique ptr please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
