HappenLee commented on code in PR #45952:
URL: https://github.com/apache/doris/pull/45952#discussion_r1900377224
##########
be/src/vec/common/sort/sorter.h:
##########
@@ -75,20 +77,20 @@ class MergeSorterState {
std::shared_ptr<Block> last_sorted_block() { return sorted_blocks_.back();
}
std::vector<std::shared_ptr<Block>>& get_sorted_block() { return
sorted_blocks_; }
- std::priority_queue<MergeSortCursor>& get_priority_queue() { return
priority_queue_; }
+ MergeSorterQueue& get_queue() { return queue_; }
void reset();
std::unique_ptr<Block> unsorted_block_;
private:
Status _merge_sort_read_impl(int batch_size, doris::vectorized::Block*
block, bool* eos);
Review Comment:
better add a TODO, change all member to `_queue` from `queue_`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
