yiguolei commented on code in PR #46200:
URL: https://github.com/apache/doris/pull/46200#discussion_r1900196750
##########
be/src/runtime/workload_group/workload_group_metrics.h:
##########
@@ -62,14 +63,15 @@ class WorkloadGroupMetrics {
std::unique_ptr<doris::MetricPrototype> _local_scan_bytes_metric {nullptr};
std::unique_ptr<doris::MetricPrototype> _remote_scan_bytes_metric
{nullptr};
// NOTE: _local_scan_bytes_metric is sum of all disk's IO
- // _local_disk_io_metric is every disk's IO
- std::map<std::string, std::unique_ptr<doris::MetricPrototype>>
_local_scan_bytes_metric_map;
-
- IntCounter* _cpu_time_counter {nullptr}; // used
for metric
- IntCounter* _mem_used_bytes_counter {nullptr}; // used
for metric
- IntCounter* _local_scan_bytes_counter {nullptr}; // used
for metric
- IntCounter* _remote_scan_bytes_counter {nullptr}; // used
for metric
- std::map<std::string, IntCounter*> _local_scan_bytes_counter_map; // used
for metric
+ std::unordered_multimap<std::string,
std::unique_ptr<doris::MetricPrototype>>
+ _local_scan_bytes_metric_map;
+
+ IntCounter* _cpu_time_counter {nullptr}; // used for metric
+ IntCounter* _mem_used_bytes_counter {nullptr}; // used for metric
+ IntCounter* _local_scan_bytes_counter {nullptr}; // used for metric
Review Comment:
这些counter 都是裸指针，他们都是啥时候析构的呢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
