Kikyou1997 commented on code in PR #9993:
URL: https://github.com/apache/incubator-doris/pull/9993#discussion_r892595594
##########
fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java:
##########
@@ -140,6 +141,60 @@ public HashJoinNode(PlanNodeId id, PlanNode outer,
PlanNode inner, TableRef inne
}
}
+ public HashJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner,
JoinOperator joinOp, List<Expr> eqJoinConjuncts,
Review Comment:
> Why this PR include `planner`?
And any other modification to Planner is based on the similiar reason as
commented above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
