yiguolei commented on code in PR #10016:
URL: https://github.com/apache/incubator-doris/pull/10016#discussion_r892190895
##########
be/src/olap/rowset/segment_v2/page_decoder.h:
##########
@@ -102,6 +102,8 @@ class PageDecoder {
bool has_remaining() const { return current_index() < count(); }
+ virtual PageDecoder* clone_for_cache() const = 0;
Review Comment:
add a default implementation here, just return __builtin_unreachable, and
other page decoder's impelementation need not implement a default
__builtin_unreachable again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
