JNSimba commented on code in PR #33:
URL:
https://github.com/apache/incubator-doris-flink-connector/pull/33#discussion_r891985882
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/deserialization/converter/DorisRowConverter.java:
##########
@@ -125,4 +181,59 @@ protected DeserializationConverter
createConverter(LogicalType type) {
throw new UnsupportedOperationException("Unsupported type:" +
type);
}
}
+
+ protected SerializationConverter createExternalConverter(LogicalType type)
{
Review Comment:
Unit tests for this method can be added to DorisRowConverterTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
