yixiutt commented on code in PR #10007: URL: https://github.com/apache/incubator-doris/pull/10007#discussion_r891948602
########## be/src/olap/task/engine_publish_version_task.cpp: ########## @@ -83,6 +83,12 @@ Status EnginePublishVersionTask::finish() { res = Status::OLAPInternalError(OLAP_ERR_PUSH_TABLE_NOT_EXIST); continue; } + { + std::shared_lock rdlock(tablet->get_header_lock()); + if (tablet->max_version().second + 1 != par_ver_info.version) { + return Status::OLAPInternalError(OLAP_ERR_ROWSET_VERSION_NOT_CONTINUOUS); Review Comment: we should retrun OLAPInternalError here so add a new error type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org