BiteTheDDDDt commented on code in PR #46056:
URL: https://github.com/apache/doris/pull/46056#discussion_r1898384588
##########
be/src/vec/exprs/table_function/vexplode.cpp:
##########
@@ -44,10 +44,9 @@ VExplodeTableFunction::VExplodeTableFunction() {
Status VExplodeTableFunction::_process_init_variant(Block* block, int
value_column_idx) {
// explode variant array
- const auto& variant_column = check_and_get_column<ColumnObject>(
- remove_nullable(block->get_by_position(value_column_idx)
- .column->convert_to_full_column_if_const())
- .get());
+ auto column_without_nullable =
remove_nullable(block->get_by_position(value_column_idx).column);
+ auto column = column_without_nullable->convert_to_full_column_if_const();
+ const auto& variant_column =
check_and_get_column<ColumnObject>(column.get());
Review Comment:
better use use assert_cast to instead check_and_get_column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
