xiaokang commented on code in PR #45833:
URL: https://github.com/apache/doris/pull/45833#discussion_r1896618690
##########
be/src/olap/rowset/segment_v2/bloom_filter.h:
##########
@@ -167,6 +167,16 @@ class BloomFilter {
return hash_code;
}
+ static Result<uint64_t> hash(const char* buf, uint32_t size,
HashStrategyPB strategy) {
+ if (strategy == HASH_MURMUR3_X64_64) {
+ uint64_t hash_code;
+ murmur_hash3_x64_64(buf, size, DEFAULT_SEED, &hash_code);
Review Comment:
use _hash_func
##########
be/src/olap/rowset/segment_v2/bloom_filter.h:
##########
@@ -167,6 +167,16 @@ class BloomFilter {
return hash_code;
}
+ static Result<uint64_t> hash(const char* buf, uint32_t size,
HashStrategyPB strategy) {
Review Comment:
can you use the function: hash(const char* buf, uint32_t size)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
