github-actions[bot] commented on code in PR #45614:
URL: https://github.com/apache/doris/pull/45614#discussion_r1891073475
##########
be/src/pipeline/task_queue.cpp:
##########
@@ -190,17 +196,24 @@
return nullptr;
}
-Status MultiCoreTaskQueue::push_back(PipelineTask* task) {
+Status MultiCoreTaskQueue::push_back(std::shared_ptr<PipelineTask> task, bool
eager) {
int core_id = task->get_previous_core_id();
if (core_id < 0) {
core_id = _next_core.fetch_add(1) % _core_size;
}
- return push_back(task, core_id);
+ return push_back(task, eager ? _eager_queue_idx : core_id);
}
-Status MultiCoreTaskQueue::push_back(PipelineTask* task, int core_id) {
- DCHECK(core_id < _core_size);
- task->put_in_runnable_queue();
+Status MultiCoreTaskQueue::push_back(std::shared_ptr<PipelineTask>& task, int
core_id) {
Review Comment:
warning: method 'push_back' can be made const
[readability-make-member-function-const]
```suggestion
Status MultiCoreTaskQueue::push_back(std::shared_ptr<PipelineTask>& task,
int core_id) const {
```
be/src/pipeline/task_queue.h:119:
```diff
- Status push_back(std::shared_ptr<PipelineTask>& task, int core_id);
+ Status push_back(std::shared_ptr<PipelineTask>& task, int core_id)
const;
```
##########
be/src/pipeline/task_queue.cpp:
##########
@@ -172,7 +178,7 @@ PipelineTask* MultiCoreTaskQueue::take(int core_id) {
return task;
}
-PipelineTask* MultiCoreTaskQueue::_steal_take(int core_id) {
+std::shared_ptr<PipelineTask> MultiCoreTaskQueue::_steal_take(int core_id) {
Review Comment:
warning: method '_steal_take' can be made const
[readability-make-member-function-const]
```suggestion
std::shared_ptr<PipelineTask> MultiCoreTaskQueue::_steal_take(int core_id)
const {
```
be/src/pipeline/task_queue.h:127:
```diff
- std::shared_ptr<PipelineTask> _steal_take(int core_id);
+ std::shared_ptr<PipelineTask> _steal_take(int core_id) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
