morrySnow commented on code in PR #45045:
URL: https://github.com/apache/doris/pull/45045#discussion_r1886081704


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -844,22 +845,28 @@ private static TFetchSchemaTableDataResult 
mtmvMetadataResult(TMetadataTableRequ
                 }
                 MTMV mv = (MTMV) table;
                 if (LOG.isDebugEnabled()) {
-                    LOG.debug("mv: " + mv.toInfoString());
+                    LOG.debug("mv: {}", mv.toInfoString());
                 }
                 TRow trow = new TRow();
-                trow.addToColumnValue(new TCell().setLongVal(mv.getId()));
-                trow.addToColumnValue(new TCell().setStringVal(mv.getName()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getJobInfo().getJobName()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getStatus().getState().name()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getStatus().getSchemaChangeDetail()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getStatus().getRefreshState().name()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getRefreshInfo().toString()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getQuerySql()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getMvProperties().toString()));
-                trow.addToColumnValue(new 
TCell().setStringVal(mv.getMvPartitionInfo().toNameString()));
-                trow.addToColumnValue(new 
TCell().setBoolVal(MTMVPartitionUtil.isMTMVSync(mv)));
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug("mvend: " + mv.getName());
+                mv.readLock();

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to