yiguolei commented on code in PR #9792:
URL: https://github.com/apache/incubator-doris/pull/9792#discussion_r884138891
##########
be/src/exec/olap_scan_node.cpp:
##########
@@ -689,11 +692,11 @@ Status OlapScanNode::build_scan_key() {
return Status::OK();
}
-static Status get_hints(TabletSharedPtr table, const TPaloScanRange&
scan_range,
- int block_row_count, bool is_begin_include, bool
is_end_include,
- const std::vector<std::unique_ptr<OlapScanRange>>&
scan_key_range,
- std::vector<std::unique_ptr<OlapScanRange>>*
sub_scan_range,
- RuntimeProfile* profile) {
+Status OlapScanNode::get_hints(TabletSharedPtr table, const TPaloScanRange&
scan_range,
Review Comment:
I do not like static method. I think we should use member function as much
as possible. And I will use it in volapscannode. It is only defined in
olap_scan_node.cpp .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
