HappenLee commented on code in PR #9520:
URL: https://github.com/apache/incubator-doris/pull/9520#discussion_r884109581
##########
be/src/vec/exprs/vexpr.h:
##########
@@ -33,10 +33,19 @@ namespace vectorized {
class VExpr {
public:
+ // resize inserted param column to make sure column size equal to
block.rows()
+ // and return param column index
+ static size_t insert_param(Block* block, ColumnWithTypeAndName&& elem) {
+ // usualy elem.column always is const column, so we just clone it.
+ elem.column = elem.column->clone_resized(std::max(block->rows(),
size_t(1)));
Review Comment:
not do `std::max` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
